search

ga4gh-beacon / beacon-v2

Unified repository for the GA4GH Beacon v2 API standard
Creative Commons Zero v1.0 Universal
27 stars 22 forks source link

Schema urgent fixes #85

Closed costero-e closed 1 year ago

costero-e commented 1 year ago

Branch of mixed fixes that can be done straight forward to develop branch because they don't belong to any specific feature. Between those fixes, we can find Handover fix for avoid the verifier to pass beacon tests, adding object type to beacon resultsets, un update in Changelog.md and removing "age" to be a title of diseases.

mbaudis commented 1 year ago

@costero-e Fine with me 👍 But generally I'd like to see such non-breaking patch fixes then also propagated to main.

costero-e commented 1 year ago

True @mbaudis, as they are hotfixes I guess we can make the PR right direct to main the next time. If you have any urgency for having them in main branch soon we can PR to main branch, too.

mbaudis commented 1 year ago

@costero-e I'll leave this to you; an important aspect is to have a branch manager w/ "decision power" :-)

(But esp. for the filters doc & the missing object type it is rather important and no downside to have it ASAP; the age part is potentially breaking though nobody should care)

costero-e commented 1 year ago

Hi @mbaudis, you are right that hotfixes have to be merged directly into main. I will close this PR and we will merge the #82 that is already open (sorry for that, I thought it was different). Thank you for the observations.