ga4gh-beacon / beacon-verifier

Tool to verify that a Beacon implementation follows the specification
2 stars 3 forks source link

mismatch between spec and verifier causing a verifier breaking error #6

Closed Tom-Shorter closed 2 years ago

Tom-Shorter commented 2 years ago

https://github.com/ga4gh-beacon/beacon-verifier/blob/ff7457ecb30558912556e2302ad4cba2c796c0b6/src/beacon.rs#L136

The responseSummary exists property should be a boolean as per the spec but the verifier is trying to access it like a string, I've had to set the exists to strings for the sake of passing the verifier and being able to test all parts of the beacon as this error causes the verifier to break.

MrRobb commented 2 years ago

You are absolutely right. I have fixed it.

Please update Rust with:

rustup update

And the verifier with:

cargo install beacon-verifier
Tom-Shorter commented 2 years ago

Thanks @MrRobb!