search

ga4gh-beacon / beacon-verifier

Tool to verify that a Beacon implementation follows the specification
2 stars 3 forks source link

Resultsets being treated as object but should be array #7

Closed Tom-Shorter closed 2 years ago

Tom-Shorter commented 2 years ago

https://github.com/ga4gh-beacon/beacon-verifier/blob/afa7c25391fd43f35d921c7e6da96f380722c980/src/beacon.rs#L153

Spec states that the resultSets should be an array of objects and not an object itself.

Looks like this issue was hiding behind the one you previously fixed (as far as I can tell the verifier will find all issues of one type, such as missing keys/wrong format value then move onto the next entity and not check for the other type of errors?).

MrRobb commented 2 years ago

This has been fixed in 781e3aa121cb1a09406a7db548cc58c8f2e54faf. Please update to version v0.2.8.

Tom-Shorter commented 2 years ago

Thanks! nothing else is popping up now :)