search

ga4gh-beacon / specification-v2

GA4GH Beacon v2 specification.
Apache License 2.0
3 stars 6 forks source link

Should `minimum` be part of `items` for "end" type? #27

Closed Relequestual closed 3 years ago

Relequestual commented 4 years ago

https://github.com/ga4gh-beacon/specification-v2/blob/de6cbe8b31659fd0800e6191f9c6d50555759bf3/beacon.yaml#L924-L935

The minimum keyword relates to numbers and is not applicable to arrays, which is the type defined for end. I assume this is just a typo and it should be indented further to be part of the items schema object.

If it's intended that end may be an array or a number, then integer should be added to the allowed types.

sdelatorrep commented 3 years ago

Fixed. Thanks, @Relequestual!