Closed mbaudis closed 3 years ago
And gladly accept corrections / refinements @ahwagner ...
Hi @mbaudis. The specification part was changed in PR #41, wasn't it? If so, I suggest closing this.
Closing since done in https://github.com/ga4gh-beacon/specification-v2/pull/41.
The current use of
referenceBases
andalternateBases
is partially incorrect when compared to the GA4GH VRS standard. While it is fine for SNVs (i.e. replacement of a single reference base by another base) or compound replacements (e.g.A > GG
), it is incorrect for simple INDELs, i.e. insertions or deletions of one or more bases w/o change of the surrounding sequence. Here, VRS states (in spirit) thatThis (preferable) use also removes some logical inconsistencies when using VCF-style "anchor" bases for INDEL variants, e.g. regarding the length of variants or their position.
However, this needs some implementation considerations:
ReferenceBases.pattern
should change from^([ACGTN]+)$
to^([ACGTN]+)?$
or^([ACGTN]*)?$
AlternateBases
ATC>A
style should not be used){start: 1234567, referenceBases: "ATC", alternateBases: "A" }
is equal to{start: 1234568, referenceBases: "TC", alternateBases: "" }
Discuss, please.