ga4gh-beacon / specification-v2

GA4GH Beacon v2 specification.
Apache License 2.0
3 stars 6 forks source link

Genome Coordinate Use and VRS #34

Closed mbaudis closed 3 years ago

mbaudis commented 3 years ago

The current use of referenceBases and alternateBases is partially incorrect when compared to the GA4GH VRS standard. While it is fine for SNVs (i.e. replacement of a single reference base by another base) or compound replacements (e.g. A > GG), it is incorrect for simple INDELs, i.e. insertions or deletions of one or more bases w/o change of the surrounding sequence. Here, VRS states (in spirit) that

This (preferable) use also removes some logical inconsistencies when using VCF-style "anchor" bases for INDEL variants, e.g. regarding the length of variants or their position.

However, this needs some implementation considerations:

Discuss, please.

mbaudis commented 3 years ago

And gladly accept corrections / refinements @ahwagner ...

sdelatorrep commented 3 years ago

Hi @mbaudis. The specification part was changed in PR #41, wasn't it? If so, I suggest closing this.

mbaudis commented 3 years ago

Closing since done in https://github.com/ga4gh-beacon/specification-v2/pull/41.