search

ga4gh-discovery / data-connect

Standard for describing and searching biomedical data developed by the Global Alliance for Genomics & Health.
Apache License 2.0
24 stars 14 forks source link

Change stance on SQL dialect support #130

Closed kemp-verily closed 3 years ago

kemp-verily commented 3 years ago

This greatly softens the language around SQL support. A short list of functions are specified as SHOULD implement, rather than a long list of MUST implement.

The expectation is that we will revise this list over time as usage dictates.

This addresses issue #128.

kemp-verily commented 3 years ago

I significantly reduced the set of functions here based on two criteria:

  1. How critical I thought it might be
  2. How broadly implemented it was

Please, push back on a removal if you think it's critical that it be done in query as opposed to after query.

mcupak commented 3 years ago

Thanks @kemp-verily. I think this is a good base, but there are probably a few more that seem at the same level of importance to me, and we've used them in examples before. How do you feel about json_extract_scalar, the other substring, like, case, cast? Maybe also contains, || and coalesce (less important)?

The broader question is - do you feel strongly about removing the remaining functions completely vs. leaving them in as optional, maybe with a MAY keyword? The idea being that you really don't have to implement them, but if you do, this is how they should behave.

kemp-verily commented 3 years ago

filed #134 to track the regex work