search

ga4gh-discovery / data-connect

Standard for describing and searching biomedical data developed by the Global Alliance for Genomics & Health.
Apache License 2.0
24 stars 14 forks source link

Update Presto examples to Trino #136

Closed jfuerth closed 2 years ago

jfuerth commented 2 years ago

The Presto examples are broken because they rely on the decommissioned search-presto.prod.dnastack.com. This updates to the new Trino implementation of everything.

jfuerth commented 2 years ago

FYI: @ianfore tested the new Docker quickstart instructions in this PR, and he was able to get up and running.

The new instructions for building data-connect-trino from source are untested because DNAstack needs to publish some jars publicly, ideally to Maven Central, so people outside the company can build it. Even so, the updated text is better than pointing people to the old ga4gh-search-adapter-presto project which doesn't work with Trino.

mcupak commented 2 years ago

@jfuerth LGTM! I modified some links pointing to the old Presto adapter, PTAL.

jfuerth commented 2 years ago

Wow, I missed a lot of old links. Thanks for the fixes!