search

ga4gh-discovery / ga4gh-case-discovery

A framework for searching genomic data sharing services
Apache License 2.0
8 stars 5 forks source link

What should be in the `patientDescription` component? #19

Open fschiettecatte opened 6 years ago

fschiettecatte commented 6 years ago

Title says it all, components/patientDescription in the request needs work.

Relequestual commented 6 years ago

This is a little ambigious. What are the issues you see?

fschiettecatte commented 6 years ago

I was not sure how to fit the patient data we have into the various fields described there. If it looks ok to you then I am ok with leaving it as is.

harindra-a commented 6 years ago

I wonder if we can again fall back on the MME "_field" format and promote those slowly into full fields as we test things out. Or simply add them as fields to start with if you need them. We can chat at next meeting on this too.

Relequestual commented 6 years ago

@fschiettecatte ah, so you meant the patientDescription component needs work, as in "components.patientDescription", not the "components and patientDescription need work", right?

Assuming so, I'm updating the title to reflect.

Relequestual commented 6 years ago

@harindra-a I think it's good that we continue to discuss specific components now, and work out how each of the pioneering services can break down their models into components, or break down existing formats like MME into almost identicall components.

Discussion about underscore prefixing is in #17, which I think we should adopt, as the positives far outweigh any negatives.

harindra-a commented 6 years ago

yup, agreed, that sounds good @Relequestual