search

ga4gh-discovery / ga4gh-case-discovery

A framework for searching genomic data sharing services
Apache License 2.0
8 stars 5 forks source link

Why is `components` an array of objects if there is only one object? #27

Closed Relequestual closed 6 years ago

Relequestual commented 6 years ago

(Asked by @fschiettecatte)

Relequestual commented 6 years ago

@fschiettecatte Which components object are you refurring to? Is it in the request / response in this repo and / or my proposal?

fschiettecatte commented 6 years ago

This is in the search request, in requires => response => components, I am not sure why the components is an array here, it feels like there will only ever be one array member that is a dictionary.

Relequestual commented 6 years ago

You're right. This was an error in my copy pasting in my proposal. I've fixed it in my proposal. I'll make a PR to fix this.

harindra-a commented 6 years ago

@Relequestual, I would say just fix it in master (or do a PR and merge it yourself or François) since it looks like an error there anyway

Relequestual commented 6 years ago

I think that's justified in this case. I'll get on it shortly.