search

ga4gh-discovery / ga4gh-case-discovery

A framework for searching genomic data sharing services
Apache License 2.0
8 stars 5 forks source link

Relequestual hybrid #4

Closed fschiettecatte closed 6 years ago

fschiettecatte commented 6 years ago

Merge in Relequestual/buske hybrid

Relequestual commented 6 years ago

I really wish you had allowed discussion on this before merging in... that's the whole point of a Pull Request, to allow discussion.

You've missed or dissregarded a few really key concepts, which without being clearly included, make it pretty pointless.

Relequestual commented 6 years ago

After a second parse of the changes, I realise it's not missing some key concepts after all. I do have one concern though regarding the use of boolean operator compoents, but we can discuss that on the call today. Apologies for my overreaction. Still, Pull Requests should allow discussion.