PRC 1 requested changes

ga4gh-discovery / ga4gh-service-info

GA4GH service-info specification.

Apache License 2.0

9 stars 8 forks source link

PRC 1 requested changes #56

Closed andrewyatz closed 4 years ago

andrewyatz commented 4 years ago

Adding logo
Documenting errors
Adding CORS
Change type into an object
Clarify service info to service mapping
Changing environment to an enum

andrewyatz commented 4 years ago

Authentication has been removed for the moment due to DURI feedback

andrewyatz commented 4 years ago

@mcupak I'm assuming we're okay to merge after PRC approved our current work

mcupak commented 4 years ago

@andrewyatz Agreed. I made a small bugfix - added prefix to the type/group field (the description said reverse domain name, but the examples were not in that format). If that looks good to you, feel free to merge.