Variant Representation

[MKonopko]

Forms submitted to Secretariat, PRC, REWS and Security 24/6.

[JoaoAndreSa]

I just found one last mention of "reference" implementation here. Just remove it and it's ready to be approved by the DSWS :)

[larrybabb]

I think Alex will need to do a new build (zip and repackage). It's his call. I do not know the process.

Alex - if you want to explain the procedure so I can be a backup going forward I'd be happy to learn and do that.

[ahwagner]

I think that @JoaoAndreSa is pointing to the vr-python GitHub description–the VR spec does not contain this text.

I'll leave it to @reece if he wants to remove the vr-python usage of "reference implementation".

[reece]

Seems not worth arguing about. I removed "reference".

For the record though, it's important to clarify that the PRC is for the spec and schema. The vr-python implementation is NOT part of the product (and therefore not part of the review).

[JoaoAndreSa]

@reece there is a link in the documentation for this repo so I thought it was part of the product. Sorry if it was not the case.

[larrybabb]

@reece do we need to state in the spec that the Implementations are not part of the spec? Should the readers of the spec have transparency on which portions of the spec were reviewed and approved by GA4GH and which were external to that review process?

[MKonopko]

@JoaoAndreSa In terms of the Security Review, we're good to go, then? Would you give us the fancy "security approved" badge if so?

[JoaoAndreSa]

@larrybabb it is somewhat already there: Security section of the README

[JoaoAndreSa]

@MKonopko in terms of security it's good to go, but it seems I cannot edit the label (maybe I don't have permission to do this)

[MKonopko]

@MKonopko in terms of security it's good to go, but it seems I cannot edit the label (maybe I don't have permission to do this)

I sent you an invite to be a collaborator. I hope that resolves the issue? If not, I will just use your written response here as official approval and change the label myself. Thanks!

[JoaoAndreSa]

It solved the problem. Already added the label :) Thanks

On 12 Aug 2019, at 16:55, MKonopko notifications@github.com wrote:

@MKonopko https://github.com/MKonopko in terms of security it's good to go, but it seems I cannot edit the label (maybe I don't have permission to do this)

I sent you an invite to be a collaborator. I hope that resolves the issue? If not, I will just use your written response here as official approval and change the label myself. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ga4gh/approval-tracker/issues/11?email_source=notifications&email_token=ACKAXOEV3LNGBAQTAX46H63QEF2WHA5CNFSM4HNXXQN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4CZKGY#issuecomment-520459547, or mute the thread https://github.com/notifications/unsubscribe-auth/ACKAXODLBC4SCED2DVRY733QEF2WHANCNFSM4HNXXQNQ.

[MKonopko]

Much appreciated!

[reece]

@JoaoAndreSa @larrybabb: You both raise a good point. I think we should clarify in the Implementations section are not supported by GA4GH. See https://github.com/ga4gh/vr-spec/issues/158 for proposal.

[julesjacobsen]

The Variant Representation specification passed the approval of the Product Review Committee on August 19th 2019.

Reviewers: @briandoconnor @melissacline @julesjacobsen

[rishidev]

Approved at GA4GH Steering Committee 2019-09