search

ga4gh / approval-tracker

GitHub repository for tracking the progress of specification approval
2 stars 0 forks source link

Discovery Search API v1 #3

Closed rishidev closed 5 years ago

rishidev commented 5 years ago

Repo for this is at https://github.com/ga4gh-discovery/ga4gh-discovery-search

geoffjentry commented 5 years ago

This looks good to me :+1:

rishidev commented 5 years ago

Nara Sobreira (PRC member) has approved this, registering on her behalf as she has no GitHub account.

rnpandya commented 5 years ago

+1 looks good to me

ckritzer commented 5 years ago

Re-write looks good!

ckritzer commented 5 years ago

I like the new Preface and the added Conventions and Terminology section. Very crisp, clean, tidy. Concept section is nicely filled out as well. Good title change for Search and Results - nothing wrong with the old title (Request and Response) but this is much clearer. Annnnnnd last but not least, yes the updates cover my question in Reserved Keys and Extensions. Very nicely done, all. Approved!

rishidev commented 5 years ago

Thank you very much to all the reviewers, this product is now ready to go to the Steering Committee meeting for Approval

rishidev commented 5 years ago

Rejected as is at Steering Committee in Basel 2018