search

ga4gh / approval-tracker

GitHub repository for tracking the progress of specification approval
2 stars 0 forks source link

Workflow Execution Service v1 #4

Closed rishidev closed 5 years ago

rishidev commented 5 years ago

Repo at https://github.com/ga4gh/workflow-execution-service-schemas/

ckritzer commented 5 years ago

Updated WES API doc reviewed and Approved! Nice work!

ohofmann commented 5 years ago

Okay from my side. Thanks for all the changes in response to the PRC requests!

mfiume commented 5 years ago

Reviewed and approved. This will go a long way for reproducible science. Thanks for your work on this.

rishidev commented 5 years ago

Comments from Aaron Kemp, 3rd PRC member. There are a couple of comments in the document - in particular: (1) repeating status codes and a question about richer errors (2) the addition of a CANCELLING state

Otherwise, LGTM

rishidev commented 5 years ago

Additional comment from Aaron Kemp, 3rd PRC member on Section 1.2 URI Descriptor on the document - we need to indicate that we are happy with a non-rooted base path.

kemp-google commented 5 years ago

LGTM subject to my comments that Rishi added above, sorry for the delay.