search

ga4gh / cat-vrs

A terminology and data model for describing categorical variation concepts.
Apache License 2.0
1 stars 2 forks source link

Review description of the CategoricalVariation.members property #70

Open mbrush opened 3 weeks ago

mbrush commented 3 weeks ago

The description of the CategoricalVariation.members property reads: "A non-exhaustive list of VRS variation Constraints that satisfy the constraints of this categorical variant." . . . the first 'Constraints' in this definition seems wrong. See here.

Shouldn't the description read "A non-exhaustive list of VRS variations that satisfy the constraints of this categorical variant" . . . or am I not understanding something?

jsstevenson commented 3 weeks ago

would it be meaningful to capitalize Variation here as well?

DanielPuthawala commented 3 weeks ago

@mbrush Thanks for catching that. Yes, that's wrong in exactly the way you describe. I'll fix it.

DanielPuthawala commented 3 weeks ago

would it be meaningful to capitalize Variation here as well?

uh.... yes iff gks:core/json/IRI objects are all of the same vrs:Variation class as well, which I think is the case. @ahwagner is that right, that all gkscore:IRI objects are ultimately vrs:Variations?

larrybabb commented 3 weeks ago

Yes, please change and create a PR