search

ga4gh / compliance

Compliance test suite for the APIs defined in ga4gh-schemas. RETIRED 2018-01-24
https://ga4gh.org
Apache License 2.0
10 stars 23 forks source link

Status code for no IDs: readSearch #187

Closed david4096 closed 8 years ago

david4096 commented 8 years ago

In SearchReads the expected status code for a request with no readgroupids is currently 501, not implemented. However the signature was changed in the reference server to return a 400. Which is correct?

[TESTLOG] FAILED searchReadsWithNoIdsFails(org.ga4gh.cts.api.reads.ReadsSearchIT) due to expected:<[501]> but was:<[400]>

diekhans commented 8 years ago

SearchReadsRequest indicates that "The ReadGroups to search. At least one id must be specified." so 400 is correct.

David Steinberg notifications@github.com writes:

In SearchReads the expected status code for a request with no readgroupids is currently 501, not implemented. However the signature was changed in the reference server to return a 400. Which is correct?

[TESTLOG] FAILED searchReadsWithNoIdsFails (org.ga4gh.cts.api.reads.ReadsSearchIT) due to expected:<[501]> but was:<[400]>

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub*

jeromekelleher commented 8 years ago

Agreed, 400 is correct.