ga4gh / g2p-team

GitHub Repo for the Genotype to Phenotype Task Team
Apache License 2.0
4 stars 0 forks source link

Time stamps on FeaturePhenotypeAssociation #13

Open sarahhunt opened 9 years ago

sarahhunt commented 9 years ago

The FeaturePhenotypeAssociation record needs time stamps. The new convention appears to be recordCreateTime and recordUpdateTime - is that correct @mbaudis ?

mbaudis commented 9 years ago

Yes and no ;-) While there is a defined format/naming for time stamps (below), there seems to be resistance to include them in the (non-metadata) objects (keeping them out of the schema & letting this be part of the local data implementations, I guess).

IMHO at least for the annotation-rich objects one should use them.

    /**
    The time at which this record was created.
    Format: ISO 8601, YYYY-MM-DDTHH:MM:SS.SSS (e.g. 2015-02-10T00:03:42.123Z)
    */
    string recordCreateTime;

    /**
    The time at which this record was last updated.
    Format: ISO 8601, YYYY-MM-DDTHH:MM:SS.SSS (e.g. 2015-02-10T00:03:42.123Z)
    */
    string recordUpdateTime;
diekhans commented 9 years ago

I don't there is resistance. We are still working on get things stabilized and synced with schemas/complaince/server/docs.

Patience my dear Watson ...

Michael Baudis notifications@github.com writes:

Yes and no ;-) While there is a defined format/naming for time stamps (below), there seems to be resistance to include them in the (non-metadata) objects (keeping them out of the schema & letting this be part of the local data implementations, I guess).

IMHO at least for the annotation-rich objects one should use them.

/**
The time at which this record was created.
Format: ISO 8601, YYYY-MM-DDTHH:MM:SS.SSS (e.g. 2015-02-10T00:03:42.123Z)
*/
string recordCreateTime;

/**
The time at which this record was last updated.
Format: ISO 8601, YYYY-MM-DDTHH:MM:SS.SSS (e.g. 2015-02-10T00:03:42.123Z)
*/
string recordUpdateTime;

— Reply to this email directly or view it on GitHub.*

sarahhunt commented 9 years ago

Thanks! So that's the format we should use here and other parts of the API will catch up later.

mbaudis commented 9 years ago

I've added a note about Common Attribute Names and Formats to the metadata_intro.rst document.

A formatted version of this can now be found at the ga4ghdata.org site.