ga4gh / ga4gh-schemas

Models and APIs for Genomic data. RETIRED 2018-01-24
http://ga4gh.org
Apache License 2.0
214 stars 114 forks source link

Get Variant Annotation by ID #534

Open david4096 opened 8 years ago

david4096 commented 8 years ago

There is a method for finding Variant Annotation Sets by their ID, but not Variant Annotations themselves. Is this intended?

https://github.com/ga4gh/schemas/blob/variation_annotation/src/main/resources/avro/alleleAnnotationmethods.avdl#L194

sarahhunt commented 8 years ago

Hi @david4096! Yes - this was an intentional ommission. The only way to get an id is to take it from the VariantAnnotation record and if you've already got the record you wouldn't want to look it up again as they don't change. We didn't consider it useful enough to add in this initial, minimal API version, but it's no problem to add the option for consistency of style.

What would be useful is a get lookup on variant id & annotation set id, but this will be a later addition.