ga4gh / ga4gh-schemas

Models and APIs for Genomic data. RETIRED 2018-01-24
http://ga4gh.org
Apache License 2.0
214 stars 114 forks source link

Rename BioSample to Biosample #697

Closed david4096 closed 7 years ago

david4096 commented 8 years ago

This suggestion closes #684 by removing the capitalization from sample. This is a welcome change that better follows common conventions. Thanks @mbaudis !

mbaudis commented 8 years ago

+1 Obviously. Thanks @david4096!

This was one of the issues which had been discussed before, but probably succumbed to branching madnessTM.

dcolligan commented 7 years ago

+1

@david4096 you can probably rebase and merge this now... small change that's been open for a month with no objections

david4096 commented 7 years ago

This will introduce breaking changes to the compliance suite, I believe. Let's wait to merge until we can verify.

ejacox commented 7 years ago

Pull doc/source/metadata_schema.png from my branch (biosample-1394, commit 0b2745f) to get the updated png file.

david4096 commented 7 years ago

Thanks @ejacox got it!

david4096 commented 7 years ago

@ejacox updated