ga4gh / ga4gh-schemas

Models and APIs for Genomic data. RETIRED 2018-01-24
http://ga4gh.org
Apache License 2.0
214 stars 114 forks source link

Replace NCBI taxon ID integer with ontology term #699

Closed david4096 closed 7 years ago

david4096 commented 8 years ago

In #612 I mentioned the inconsistency in representing the NCBI taxon ID as an integer on a reference when the biometadata objects use an Ontology term. This PR closes #612 by replacing the NCBI taxon ID int32 with an ontology term.

mbaudis commented 8 years ago

-1 on this in the current implementation.

Species is defined inbio_metadata.Individual.species

So this should be a reference to the individual (or a copy of the same structure, as a fudge; i.e. OntologyTerm species instead of OntologyTerm ncbi_taxon_id).

  // For a representation of an NCBI Taxon ID as an OntologyTerm, see
  // NCBITaxon Ontology
  //   http://www.obofoundry.org/ontology/ncbitaxon.html
  // For example, 'Homo sapiens' has the ID 9606. The NCBITaxon ontology ID for
  // this is NCBITaxon:9606, which has the URI
  // http://purl.obolibrary.org/obo/NCBITaxon_9606
  OntologyTerm species = 7;
david4096 commented 8 years ago

Thanks @mbaudis, that makes sense I've changed the field to be named species.

mbaudis commented 8 years ago

+1 (and removal of the -1 above)

david4096 commented 7 years ago

Updated to include using an Ontology Term on reference sets as well. Thanks @ejacox !

david4096 commented 7 years ago

Implemented in the server here, and client with demonstrated tests in compliance.