search

ga4gh / ga4gh-schemas

Models and APIs for Genomic data. RETIRED 2018-01-24
http://ga4gh.org
Apache License 2.0
214 stars 110 forks source link

Add Biosample ID to quantification #705

Closed david4096 closed 8 years ago

david4096 commented 8 years ago

This PR allows one to filter RNA quantifications by bio_sample_id.

Currently, RNA quantifications are not given a bio_sample_id field. RNA quantifications can be optionally associated with read group IDs, which in turn are tagged by biosample. This addition allows one to query RNA quantifications by bio_sample_id directly, retaining the redundancy in read groups. This is done by adding it to the quantification message and search request. @saupchurch

saupchurch commented 8 years ago

Looks reasonable to me and covers the case where a read group ID may not be available. +1

kozbo commented 8 years ago

@dcolligan This will be coming next after the work you are doing on server #1368. Something to keep in mind.

mbaudis commented 8 years ago

+1 (but please remember https://github.com/ga4gh/schemas/issues/684)

dcolligan commented 8 years ago

+1 with @mbaudis 's proviso

kozbo commented 8 years ago

@mbaudis we haven't forgotten #684, coming soon! Merging this first.