search

ga4gh / ga4gh-schemas

Models and APIs for Genomic data. RETIRED 2018-01-24
http://ga4gh.org
Apache License 2.0
214 stars 114 forks source link

Multiple Ontology Term URIs #708

Closed david4096 closed 7 years ago

david4096 commented 8 years ago

From https://github.com/ga4gh/schemas/pull/694

Ontology Terms can be represented by multiple unique URIs. Perhaps we should allow multiple term_uris to be defined for any Ontology Term?

@jmcmurry added a line comment 4 hours ago

If multiple discrepant URIs exist and are known, what is the plan for describing / collapsing them?

mbaudis commented 8 years ago

-1 on this.

I am not sure how this would be of any benefit - iterating through the if one doesn't resolve? But then, which precedence? This should better be addressed captured through a service which remaps ontologies/URIs of moved/deprecated end points.

mcourtot commented 7 years ago

I would recommend not to. Instead, as per https://github.com/ga4gh/schemas/issues/695, we'll rely on an external registry. Note that this may imply we remove the termURI attribute at a next iteration, but would provide greater flexibility to redirect towards active resolvers.

david4096 commented 7 years ago

@jmcmurry care to comment?

jmcmurry commented 7 years ago

No perfect solution but agree w/ @mcourtot that reliance on OLS is the way to go. Any objections? How close are they to having API access to their registry?

mcourtot commented 7 years ago

Pinging @simonjupp. Note this relates to the discussion during the Vancouver meeting and at https://github.com/ga4gh/schemas/pull/694. In short, we decided to keep CURIE + label to denote ontology terms and remove other attributes.