search

ga4gh / ga4gh-schemas

Models and APIs for Genomic data. RETIRED 2018-01-24
http://ga4gh.org
Apache License 2.0
214 stars 114 forks source link

Rename SearchGenotypePhenotypeRequest/Response #715

Open bwalsh opened 7 years ago

bwalsh commented 7 years ago

The endpoint /genotypephenotypes/search was refactored to /featurephenotypeassociations/search - this was done to make the endpoint name consistent with the name of the entity type returned.

Should the request & response object types should be renamed as well? SearchGenotypePhenotypeRequest -> SearchFeaturePhenotypeAssociationRequest SearchGenotypePhenotypeResponse -> SearchFeaturePhenotypeAssociationResponse

From: Coffman, Adam [acoffman@wustl.edu]
Sent: Wednesday, September 14, 2016 1:34 PM
To: Sarah Hunt; Brian Walsh; Linda Huang; Ravi Pandya; Wagner, Alex
Subject: Re: GA4GH-G2P: Schemas endpoint name change

Hi Brian,

The naming change should be no big deal to implement. Is it intentional that the request and response object types are still SearchGenotypePhenotypeRequest and SearchGenotypePhenotypeResponse even though that is no longer the name of the endpoint?

Adam
david4096 commented 7 years ago

Yes, I think so. It makes more sense to talk about the actual messages in the data model. +1 for changing these