ga4gh / ga4gh-schemas

Models and APIs for Genomic data. RETIRED 2018-01-24
http://ga4gh.org
Apache License 2.0
214 stars 114 forks source link

Highly misleading comments in schemas/src/main/proto/ga4gh/genotype_phenotype_service.proto #719

Closed shadowtramp closed 7 years ago

shadowtramp commented 7 years ago

The file schemas/src/main/proto/ga4gh/genotype_phenotype_service.proto contains highly misleading comment sections, specifying, that most search methods return instance of SearchPhenotypeAssociationSetsResponse, while methods SearchPhenotype and SearchPhenotypeAssociations have prototypes. returning different messages.

bwalsh commented 7 years ago

@shadowtramp thanks very much for the feedback. Can you review change?

shadowtramp commented 7 years ago

Thanks! That fixes it. Do I need to do some formal reviewing somehow?

bwalsh commented 7 years ago

@shadowtramp Thanks for the quick turn around. That should do it. @kozbo Should be ok for merge.

kozbo commented 7 years ago

@shadowtramp We will count that as your +1 :-)