Closed shadowtramp closed 7 years ago
@shadowtramp thanks very much for the feedback. Can you review change?
Thanks! That fixes it. Do I need to do some formal reviewing somehow?
@shadowtramp Thanks for the quick turn around. That should do it. @kozbo Should be ok for merge.
@shadowtramp We will count that as your +1 :-)
The file schemas/src/main/proto/ga4gh/genotype_phenotype_service.proto contains highly misleading comment sections, specifying, that most search methods return instance of SearchPhenotypeAssociationSetsResponse, while methods SearchPhenotype and SearchPhenotypeAssociations have prototypes. returning different messages.