ga4gh / ga4gh-schemas

Models and APIs for Genomic data. RETIRED 2018-01-24
http://ga4gh.org
Apache License 2.0
214 stars 114 forks source link

Inconsistency - Typo #722

Closed achave11-ucsc closed 7 years ago

achave11-ucsc commented 7 years ago

In all the requests for get elements by id. There is a pattern for both GET and POST method the only thing that changes is the /search or /{element_id} found /rnaquantification/{rna_quantification_id} inconsistent with /rnaquantifications/search https://github.com/ga4gh/schemas/blob/master/src/main/proto/ga4gh/rna_quantification_service.proto#L148

david4096 commented 7 years ago

Thanks! It looks like the comment is incorrect, however, the actual annotated paths are the way you describe. Namely, /rnaquantifcations/{rna_quantification_id} https://github.com/ga4gh/schemas/blob/master/src/main/proto/ga4gh/rna_quantification_service.proto#L51 .