search

ga4gh / ga4gh-schemas

Models and APIs for Genomic data. RETIRED 2018-01-24
http://ga4gh.org
Apache License 2.0
214 stars 110 forks source link

time format fixes #729

Closed mbaudis closed 7 years ago

mbaudis commented 7 years ago

Fixing lurking “milliseconds from epoch” times (has been done before, but somehow crept in again due to branching madness)

david4096 commented 7 years ago

Covered here.

mbaudis commented 7 years ago

@david4096 @kozbo

Yes; & thanks for the reminder of an older PR which was based on my own comments https://github.com/ga4gh/schemas/issues/637.

But then, it is kind of confusing which things are in the pipeline & which are just forgotten / victims of branching madness ...

Proposal (involves work!): Push notes into master describing the accepted changes, which are just held back due to custodial concerns.

Example:

 // The time at which this read group was created in milliseconds from the epoch.
   int64 created = 9;
// TODO (accepted): The :ref:`ISO 8601<metadata_date_time>` time at which this record was created.
// TODO (accepted): string created = 15;
mbaudis commented 7 years ago

Closing in favour of https://github.com/ga4gh/schemas/pull/690.