ga4gh / ga4gh-schemas

Models and APIs for Genomic data. RETIRED 2018-01-24
http://ga4gh.org
Apache License 2.0
214 stars 114 forks source link

Put proto files under ga4gh_schemas directory #731

Closed dcolligan closed 7 years ago

dcolligan commented 7 years ago

This change will allow protoc to compile pb2 files in a way that fits our pypi packaging strategy.

Here is the repository that is packaging the ga4gh_schemas pypi package (this will be moved from my personal repo to a ga4gh repo soon): https://github.com/dcolligan/ga4gh-schemas

david4096 commented 7 years ago

Could you explain more why this is the case? Can we use our organization ga4gh as the package and class off of that. Is there an approach that allows us to make this change without restructuring the directories? Perhaps a script can make the namespace alterations.

dcolligan commented 7 years ago

@david4096 the second commit in this PR implements the hierarchical namespace.

We could alternately pursue the script approach...

dcolligan commented 7 years ago

Abandoned in favor of #740