Closed dcolligan closed 7 years ago
Example of this failure: https://travis-ci.org/ga4gh/server/builds/194838639
Yeah, I specifically deprecated the common elements of process schemas to avoid this. I think it's OK to duplicate code if it's needed to perform installation like this.
I would keep process schemas as something simple that can run inside setup.py with no dependencies.
I also think the development interface of python setup.py develop
for running process schemas to be pretty sensible and idiomatic. That will install the deps and generate pb2 files from the proto.
So maybe we keep common and use it in schemas where we can, but just not for this part.
Ok, this issue has now changed to: fix the install path by removing references to ga4gh-common from the install path.
Fixed (as it were) in #798
Now that we are depending on
ga4gh-common
forprocess_schemas.py
which is used insetup.py
, the install can fail if the common package is not available before install happens (see below). The solution is to remove any references toprocess_schemas.py
fromsetup.py
.(This problem is post-0.6.0a9-release, so it doesn't affect our released packages, only development.)