ga4gh / ga4gh-schemas

Models and APIs for Genomic data. RETIRED 2018-01-24
http://ga4gh.org
Apache License 2.0
214 stars 114 forks source link

Add protocol.py #801

Closed dcolligan closed 7 years ago

dcolligan commented 7 years ago

Issue https://github.com/BD2KGenomics/ga4gh-integration/issues/53

david4096 commented 7 years ago

This removes redundant code and will make the schemas python module much easier to use.

dcolligan commented 7 years ago

@david4096 ready for review

dcolligan commented 7 years ago

Actually, hold on... there's a few problems.

https://travis-ci.org/ga4gh/server/builds/199079898

I need to add the encodeValue and setAttribute methods and fix getValueFromValue

dcolligan commented 7 years ago

@david4096 ok, should be good now

david4096 commented 7 years ago

CI is failing and I'm not able to replicate locally. It seems like it might be a CI bug working off a different commit? Gonna try closing and reopening.