search

ga4gh / ga4gh-schemas

Models and APIs for Genomic data. RETIRED 2018-01-24
http://ga4gh.org
Apache License 2.0
214 stars 114 forks source link

Addition of sample source #823

Closed mcourtot closed 7 years ago

mcourtot commented 7 years ago

as per https://github.com/ga4gh/schemas/issues/707

mbaudis commented 7 years ago

Please see https://github.com/ga4gh/ga4gh-schemas/pull/836 ; the type of biocharacteristic can now be addressed through a characteristics_class attribute.

twhetzel commented 7 years ago

@mbaudis related to #836, is this now called scope following the comment from @mcourtot ?

mbaudis commented 7 years ago

@twhetzel Yes; this PR can be closed since implemented here. The structure with separate phenotypes, diseases, sample_source is gone & has been replaced with a scope attribute (though this itself could be renamed/changed in type...).