search

ga4gh / ga4gh-schemas

Models and APIs for Genomic data. RETIRED 2018-01-24
http://ga4gh.org
Apache License 2.0
214 stars 110 forks source link

Peer service improvements #848

Closed david4096 closed 1 year ago

david4096 commented 7 years ago

Move the Peer message to its own file.

Add a remote_address field to the GetInfoResponse which can be used to reflect on the origin of a request. This makes it easier to make well formed announce messages in mixed network environments.

kozbo commented 7 years ago

I discussed this with @ejacox and I now think you were right to keep the messages together with the data. The peer service has nothing to do with the representation of genomic data. It is associated with serving the data and as such should be represented as a protocol only.

@david4096 : you responded to my questions very quickly with this PR. Thanks for your quick reaction :-) Let's go with your first design and close this PR without merging. So, -1 with apologies, since I suggested it in the first place!

david4096 commented 7 years ago

No problem, updated!

david4096 commented 7 years ago

This is intended for a future release, we haven't implemented the remote_address functionality yet.

kozbo commented 7 years ago

thanks @david4096