ga4gh / ga4gh-schemas

Models and APIs for Genomic data. RETIRED 2018-01-24
http://ga4gh.org
Apache License 2.0
214 stars 110 forks source link

Change booleans to enums #869

Open david4096 opened 7 years ago

david4096 commented 7 years ago

For any field where the default boolean should not be considered false, we should offer an enum that states "no value selected" or "null" that is the default. This is currently a bug that makes documents incorrect when the values aren't known, since False is assumed.

For example, improper_placement on an alignment. https://github.com/ga4gh/ga4gh-schemas/blob/master/src/main/proto/ga4gh/reads.proto#L140