Client sends 0 page size

ga4gh / ga4gh-server

Reference implementation of the APIs defined in ga4gh-schemas. RETIRED 2018-01-24

http://ga4gh.org

Apache License 2.0

96 stars 91 forks source link

Client sends 0 page size #1362

Open david4096 opened 8 years ago

david4096 commented 8 years ago

When attempting to use the client against another GA4GH server it was found that it defaults to send a pageSize of 0. {u'pageToken': u'', u'pageSize': 0} are sent with the first request. This bug caused the client to continually request empty pages.

jeromekelleher commented 8 years ago

Surely this is a bug in the other GA4GH server? Sending a page size of 0 allows the server to decide what the size of the returned page is, making process slightly less inefficient.

dcolligan commented 8 years ago

Yeah, this sounds like a non-bug to me... we have self._defaultPageSize = 100 in backend.py which the page size is set to if the client sends a page size of 0.

Closing...