ga4gh / ga4gh-server

Reference implementation of the APIs defined in ga4gh-schemas. RETIRED 2018-01-24
http://ga4gh.org
Apache License 2.0
96 stars 93 forks source link

Make referencesets optional when possible #1596

Open david4096 opened 7 years ago

david4096 commented 7 years ago

The repo manager requires that a reference set is provided when it is really only a metadata item from the perspective of the variants, features, and RNA. For this reason, we can make it an optional flag at the repo manager.

I am able to add a variant set using just: python repo_dev.py add-variantset ga4gh-example-data/registry.db brca1 ga4gh-example-data/brca1_1kgPhase3_variants.vcf.gz

We should strongly consider a PR at the schemas that removes the referenceId as a required field of a reads search, as that is the only endpoint that can't implement this feature.

Works to close #1528, thanks @ejacox for helping us keep focus on usability features.