search

ga4gh / ga4gh-server

Reference implementation of the APIs defined in ga4gh-schemas. RETIRED 2018-01-24
http://ga4gh.org
Apache License 2.0
96 stars 91 forks source link

Remove converters #1610

Closed dcolligan closed 7 years ago

dcolligan commented 7 years ago

Issue #1457

Deleting these from the server repo, which everyone seems to agree is a good idea... the issue of where to put them, if anywhere, can be solved elsewhere.

codecov-io commented 7 years ago

Codecov Report

Merging #1610 into master will increase coverage by 0.42%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1610      +/-   ##
==========================================
+ Coverage   85.89%   86.32%   +0.42%     
==========================================
  Files          36       33       -3     
  Lines        7794     7569     -225     
  Branches      969      935      -34     
==========================================
- Hits         6695     6534     -161     
+ Misses        892      841      -51     
+ Partials      207      194      -13
Impacted Files Coverage Δ
ga4gh/server/cli/init.py 92.3% <0%> (-7.7%) :x:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f9a6bce...9b627f3. Read the comment docs.

david4096 commented 7 years ago

Thanks for doing this. We'll definitely get back here https://github.com/ga4gh/ga4gh-server/issues/83

Codecov showed me this dead code that you can remove from cli/__init__

https://github.com/ga4gh/ga4gh-server/blob/c5306d516a629d729840681f56c05df4441a76f0/ga4gh/server/cli/__init__.py#L37

+1