david4096 commented 7 years ago

Thank you SOOO much @Welliton309 for writing these docs. The community could really benefit from easier authentication/authorization solutions!

This PR fixes a problem found in #1565 that Auth0 changed the formatting of their client secrets (no longer b64 encoded). This PR fixes that to support all future Auth0 clients.

The links to the images are hosted by github's cache, which is probably not a great solution and they should be checked in.

TODO

~~Move images to static directory.~~

codecov-io commented 7 years ago

Codecov Report

Merging #1620 into master will decrease coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1620      +/-   ##
==========================================
- Coverage   86.65%   86.65%   -0.01%     
==========================================
  Files          33       33              
  Lines        7471     7469       -2     
  Branches      926      926              
==========================================
- Hits         6474     6472       -2     
  Misses        805      805              
  Partials      192      192

Impacted Files	Coverage Δ
ga4gh/server/auth/init.py	`66.66% <ø> (-0.63%)`	:x:
ga4gh/server/serverconfig.py	`100% <100%> (ø)`	:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ec57524...44c3e82. Read the comment docs.

kozbo commented 7 years ago

+1, and merging

ga4gh / ga4gh-server

Add Auth0 docs and ~b64decoding #1620

Codecov Report