search

ga4gh / ga4gh-server

Reference implementation of the APIs defined in ga4gh-schemas. RETIRED 2018-01-24
http://ga4gh.org
Apache License 2.0
96 stars 91 forks source link

Server does not always return next page token #1635

Closed wdesouza closed 7 years ago

wdesouza commented 7 years ago

I noticed that the 1kgenomes server (http://1kgenomes.ga4gh.org/) does not return nextPageToken attribute when response data size is less or equal pageSize. It only returns this attribute when there is some value for nextPageToken. It was not the default behavior previously, which the same server always returned nextPageToken = "" by default. Is this the default behavior now?

david4096 commented 7 years ago

Yes, we changed the protobuf serialization to not include empty keys.

Did this break your client? It's probably safer in your client to check for the presence of a key before checking it's value. If that works for you we can close this. For more https://github.com/ga4gh/ga4gh-server/issues/1588

wdesouza commented 7 years ago

Thank you @david4096. I will update my software client. I checked the presence of keys that are optional. I thought that nextPageToken would always present. Knowing that any empty key will be omitted I will take more attention.