Clarify application of `Type` attribute throughout model

ga4gh / gks-common

Common classes and schemas used by all GKS specifications (ie. VR, VA, etc..)

Apache License 2.0

2 stars 0 forks source link

Clarify application of `Type` attribute throughout model #7

Closed larrybabb closed 3 hours ago

larrybabb commented 3 weeks ago

https://github.com/ga4gh/gks-common/blob/05ba1bffd042122aad01f3be0cca9c23ecd8549f/schema/gks-common/core-source.yaml#L94C7-L97C42

Why does Extension have a type attribute but nothing else does? Let's clarify how we are applying the type attribute across GKS schemas for clarity.

mbrush commented 2 weeks ago

See also issue #5 - and comments therein.

larrybabb commented 3 hours ago

The answer is 'No'. Since Extension does not inherit from Entity. Only Entity subtypes are required to have a type field unless someone has an argument to present otherwise.