ga4gh / mme-apis

Documentation for the MatchmakerExchange APIs
https://github.com/ga4gh/mme-apis
34 stars 19 forks source link

Look at use of ICHPT for translating between phenotype ontologies #56

Closed Relequestual closed 8 years ago

Relequestual commented 9 years ago

ICHPT mappings have not yet been finalised or officially released.

We have been advised by Ada to wait for the paper and official website release (digestable format) of the mappings before seeking to implement usage.

allasm commented 9 years ago

Potentially related to #52

buske commented 9 years ago

Does this mean that we should remove ICHPT from the upcoming version of the API we're trying to release?

fschiettecatte commented 9 years ago

I am ok with removing it for now given that we are waiting on Peter for his input/blessing. I am not going to remove support from GeneMatcher since it is already in there, so we will accept ICHPT terms based on Ada's mappings, but we will only emit HPO.

buske commented 9 years ago

+1

It's a backwards-compatible change to add it back in later, so I think we should remove it for now.

Relequestual commented 8 years ago

ICHPT has since been released!

Is there any system in MME that this would be benificial for? ICHPT allows for mapping, but HPO is more descriptive! There's no reason a system can't get a copy of ICHPT (now) and then translate to their phenotype ontology of choosing that it supports.

I think it would actually be detrimental to use ICHPT as the across the wire format, as information would be lost going from HPO to ICHPT and back to HPO.

fschiettecatte commented 8 years ago

It makes most sense to use HPO only for MME going forward. I don't think anyone has expressed an interest or need in using anything else. ICHPT has value but not for MME.

Relequestual commented 8 years ago

Voting to close this issue.

fschiettecatte commented 8 years ago

+1

buske commented 8 years ago

+1 Let's close this until groups have clear use cases that require it.

buske commented 8 years ago

Closing due to 3 votes.