Rename fields in Relationship model

ga4gh / pedigree

Repository for the family history/pedigree project

https://pedigree.readthedocs.io/

11 stars 3 forks source link

Rename fields in Relationship model #13

Open buske opened 2 years ago

buske commented 2 years ago

In this issue, @julesjacobsen suggested renaming the fields in Relationship to be:

subject: identifier of the subject Individual; equivalent to the Biolink "Subject"
relative: identifier of the relative Individual; equivalent to the Biolink "Object"
relationship: the relationship the subject has to the relative (e.g., if the subject is the relative's parent, then relationship would be a descendant of isBiologicalParent[Of])

buske commented 2 years ago

Now that the terms in the KIN ontology are directional, updating these property names is helpful for clarifying this direction. I went ahead and committed this change, but realized now that this breaks the FHIR IG, so think we should hold off on this change until discussing at/after Connect.