ga4gh / pedigree_family_history_terminology

Apache License 2.0
4 stars 3 forks source link

OtherSex insufficiently distinguished from UnknownSex #30

Open cmungall opened 2 years ago

cmungall commented 2 years ago

You have an axiom:

Sex = Female or Male (both of which are disjoint)

Leaving aside for now the accuracy of this model, let's accept this is your model. It is designed to expressly forbid sex being anything than one of the two. OWL is open world, so it still allows lack of commitment, but the underlying model must be one of the two.

Sex has two other subclasses:

Purely on the textual level, these seem insufficiently distinguished. That modal qualifier is doing a lot of work for you. This also seems a counterintuitive use of the term "other". This also implies other is a subclass of unknown.

I realize this is a difficult area but I think if you do adopt a strictly binary model then this should be more transparent, and use a different adjective than Other, if the system doesn't truly admit Other. You could still have a qualifier that involves identification. Maybe aligning with GSSO will help.

ngo010 commented 1 year ago

By aligning with GSSO, can we modify the Sex group as follows: