search

ga4gh / pedigree_family_history_terminology

Apache License 2.0
4 stars 3 forks source link

isGreatGrandchildOf has incorrect altLabel #32

Closed cmungall closed 1 year ago

cmungall commented 2 years ago

altLabel should be used for alternative labels/synonyms/aliases

This would make this wrong:

isGreatGrandchildOf skos:altLabel "hasGreatGrandparent"^^rdfs:Literal

the altlabel is actually for the inverse. Either name the inverse and make this string a property of that, or use a different annotation property such as antonymOf

balhoff commented 1 year ago

@cmungall I don't think you're right here. The inverse would be "isGreatGrandparentOf", but this is has.

Both make sense:

cmungall commented 1 year ago

Doh, You're right! Somehow I missed the switch from child/parent in the label

On Fri, Oct 28, 2022 at 6:54 PM Jim Balhoff @.***> wrote:

@cmungall https://github.com/cmungall I don't think you're right here. The inverse would be "isGreatGrandparentOf", but this is has.

Both make sense:

  • Annie isGreatGrandchildOf Erasmus
  • Annie hasGreatGrandparent Erasmus

— Reply to this email directly, view it on GitHub https://github.com/GA4GH-Pedigree-Standard/family_history_terminology/issues/32#issuecomment-1295684475, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMMOLZ7Q7E74IRTEG5RNDWFR7WVANCNFSM5227SAUQ . You are receiving this because you were mentioned.Message ID: <GA4GH-Pedigree-Standard/family_history_terminology/issues/32/1295684475@ github.com>