ga4gh / pedigree_family_history_terminology

Apache License 2.0
4 stars 3 forks source link

FHT implies that everyone's mother and father are cousins (and all parents are cousins to themselves) #33

Closed cmungall closed 2 months ago

cmungall commented 2 years ago

The property chain flows in the wrong direction:

isBiologicalParentOf o isBiologicalSiblingOf o isBiologicalChildOf SubPropertyOf: isCousinOf

this leads to every parent of more than one child being self-cousins, and pairs of parents of siblings as being classed as being cousins:

To test this, I ontologized the Simpsons, and then asked who was Marge's cousin:

image

These are all the inferences about Homer:

image

I think there is maybe some general confusion about directionality of relations in the ontology?

here is the test:

# Individual: <http://example.org/simpson/4038> (Homer)

AnnotationAssertion(rdfs:label <http://example.org/simpson/4038> "Homer"@en)
ObjectPropertyAssertion(<http://purl.org/ga4gh/kin.owl#KIN_028> <http://example.org/simpson/4038> <http://example.org/simpson/4040>)

# Individual: <http://example.org/simpson/4039> (Marge)

AnnotationAssertion(rdfs:label <http://example.org/simpson/4039> "Marge"@en)

# Individual: <http://example.org/simpson/4040> (Bart)

AnnotationAssertion(rdfs:label <http://example.org/simpson/4040> "Bart"@en)
ObjectPropertyAssertion(<http://purl.org/ga4gh/kin.owl#KIN_007> <http://example.org/simpson/4040> <http://example.org/simpson/4041>)

# Individual: <http://example.org/simpson/4041> (Lisa)

AnnotationAssertion(rdfs:label <http://example.org/simpson/4041> "Lisa"@en)
ObjectPropertyAssertion(<http://purl.org/ga4gh/kin.owl#KIN_032> <http://example.org/simpson/4041> <http://example.org/simpson/4039>)
cmungall commented 2 months ago

Fixed by #38