ga4gh / pedigree_family_history_terminology

Apache License 2.0
4 stars 3 forks source link

isBiologicalSiblingOf is incorrectly declared transitive #34

Closed cmungall closed 2 months ago

cmungall commented 2 years ago

A relation between two people that have one or both biological parents in common.

  1. c1 hasBiologicalMother m1
  2. c1 hasBiologicalFather f1
  3. c2 hasBiologicalMother m2
  4. c2 hasBiologicalFather f1. shared with c1
  5. c3 hasBiologicalMother m2 shared with c2
  6. c3 hasBiologicalFather f2

from the text definition we infer

From transitivity we infer

But this violates the text definition

cmungall commented 2 years ago

Transitivity of isRelativeOf is a little suspect - we would infer that every person on earth is related to every other. Which is not untrue in some sense of "relative" but maybe not in the intended sense of A relation that indicates that a person is connected to another biologically or through a socio-legal relationship

cmungall commented 2 months ago

Fixed by #37