search

ga4gh / quality-control-wgs

Home for the GA4GH Quality Control of Whole Genome Sequencing metrics and reference implementations
https://www.ga4gh.org/product/wgs-quality-control-standards/
Apache License 2.0
14 stars 3 forks source link

improved `yield_bp_q30` metric definition #8

Closed nicolas-bertin closed 1 year ago

nicolas-bertin commented 1 year ago

proposal to improve yield_bp_q30 metric definition from

https://github.com/ga4gh/quality-control-wgs/blob/e692682078a3f47b8160cc1ef74614227264b847/metrics_definitions/metrics_definitions.md?plain=1#L19-L35

to [edit: fix typo]

https://github.com/ga4gh/quality-control-wgs/blob/bddde198a26f1311a0188f8792b71d6fe704949d/metrics_definitions/metrics_definitions.md?plain=1#L21-L27

see #7

justinjj24 commented 1 year ago

typo in https://github.com/ga4gh/quality-control-wgs/blob/0290612d0237078dea7ae38dc13e680189fc46d1/metrics_definitions/metrics_definitions.md?plain=1#L25 GATK Picard’s CollectQualityYieldMetric should read GATK Picard’s CollectQualityYieldMetrics

mhebrard commented 1 year ago

Fix typo & phrasing:

https://github.com/ga4gh/quality-control-wgs/blob/bddde198a26f1311a0188f8792b71d6fe704949d/metrics_definitions/metrics_definitions.md?plain=1#L21-L27