search

ga4gh / task-execution-schemas

Apache License 2.0
81 stars 28 forks source link

OAPI 2.0 Swagger YAML #113

Closed susheel closed 5 years ago

susheel commented 5 years ago

Converted Swagger JSON into YAML help with future updates and fixes. Starting work towards #109 and beyond

susheel commented 5 years ago

TODO: Still have to sanity check the required and optional attributes of the models

delagoya commented 5 years ago

Two issues:

  1. remove the JSON if the YAML is the canonical version.
  2. Looks like this PR implicitly approves #105 . Will need community comment and approve on that before merging.
susheel commented 5 years ago

@delagoya

  1. https://github.com/ga4gh/task-execution-schemas/pull/113/commits/c61942d26647eb77372c64de5cfc665f8580b2d1 removes the JSON spec
  2. Yes, it does. I can split this out into a separate pull so this would be easier to merge.
delagoya commented 5 years ago

Right. Will revert master. Can we safely push this to develop branch?

delagoya commented 5 years ago

Or actually these are already in the new develop branch.

delagoya commented 5 years ago

Suggest we rebase master to 0765b930542ebd8124d5b42109fe81916129f99c ish instead of a separate PR that reverts changes as new commits.