search

ga4gh / task-execution-schemas

Apache License 2.0
80 stars 28 forks source link

Rename TaskParameter.{location, path} to have more meaningful names #14

Closed buchanae closed 7 years ago

buchanae commented 7 years ago

TaskParameter.location and TaskParameter.path refer to file locations on the storage drive and worker drive, respectively. While coding these into cromwell, we realized that these names weren't very intuitive and we kept needing to refer back to the TES proto spec to read the comments.

I think we can come up with better names that make the value of these attributes clear. My suggestion is

location => storagePath path => containerPath

kellrott commented 7 years ago

The location field was original based on the location field in CWL: http://www.commonwl.org/v1.0/CommandLineTool.html#File

Instead of location or storagePath would url be useful?

buchanae commented 7 years ago

url works for me

bwalsh commented 7 years ago

Spoke to alex, agree it should be 'url'. DMS currently has no concept of 'storage' vs 'container' (it's implied that it would be 'storage')