ga4gh / task-execution-schemas

Apache License 2.0
80 stars 28 forks source link

Remove JobID message type #27

Closed buchanae closed 7 years ago

buchanae commented 7 years ago

Removing the JobID message cleans up the messages and related code a bit. Schema clients previously needed code like:

jobid := JobID.Value

...which I didn't like looking at :)

This also allows the request/response message types to grow in the future, without worrying about whether that field belongs on a "JobID" message. And it's a more consistent pattern. Most RPC endpoints have an EndpointNameRequest message and an EnpointNameResponse message.

geoffjentry commented 7 years ago

👍