ga4gh / task-execution-schemas

Apache License 2.0
80 stars 28 forks source link

suggestions for more consistent field names in Executor #83

Closed prismofeverything closed 6 years ago

prismofeverything commented 6 years ago

Going through the schema and implementing a remote interface for funnel, all of the field names are so concise and elegant that these three field names stuck out.

I am proposing three changes:

Most of the other fields throughout the schema are single names, and the word image does not need to be disambiguated with any other fields in the schema, so this seems like the natural choice.

The schema is refreshingly light on abbreviated names to the point where this one stands out. Why not just command?

This one is funny because it is really just a different abbreviation of environment. I would almost prefer environment since it is nice to be clear, but we have such a long-standing tradition of using the three letters ENV to stand for the environment (even the bash program called env) that I think this one makes sense.

Open to all thoughts and ideas on this.

briandoconnor commented 6 years ago

Changes seems fine to me

geoffjentry commented 6 years ago

:+1: this all seems right

pditommaso commented 6 years ago

👍

buchanae commented 6 years ago

@prismofeverything can you update the README as well please?

prismofeverything commented 6 years ago

Okay, done.