search

ga4gh / tool-registry-service-schemas

APIs for discovering genomics tools, their metadata and their containers
Apache License 2.0
30 stars 18 forks source link

Clean-up and/or conversion issues from swagger 2.0 to openapi #229

Closed denis-yuen closed 1 year ago

denis-yuen commented 1 year ago
  1. The swagger 2.0 is still kicking around the develop branch https://github.com/ga4gh/tool-registry-service-schemas/blob/develop/openapi/ga4gh-tool-discovery.yaml (on 2022-12-05). This looks like a bad merge conflict since it was supposed to be removed in https://github.com/ga4gh/tool-registry-service-schemas/commit/e164249991370ac3748ab8b5d8e4a872b22cd0b5
  2. One endpoint has a plain/text response when it does not make sense https://github.com/ga4gh/tool-registry-service-schemas/blob/v2.0.1/openapi/openapi.yaml#L43-L45 . The plain text response was intended only for endpoints that return descriptors, this was likely a regression/conversion error since the swagger version does not have this issue

FYI @coverbeck

┆Issue is synchronized with this Jira Story ┆Project Name: Zzz-ARCHIVE GA4GH tool-registry-service ┆Issue Number: TRS-63